Add C++20 proposal #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwak-work
reviewed
Mar 31, 2025
|
Agree we should have a risks. Also what about customer impact and dependency considerations? @expipiplus1 suggest you run this proposal through an LLM to get some feedback. |
expipiplus1
force-pushed
the
push-qstqksskvznv
branch
from
fc7511a to
a55ca17
Compare
expipiplus1
force-pushed
the
push-qstqksskvznv
branch
from
a55ca17 to
86a80ad
Compare
Contributor
Author
|
I've added a risks section with the requested info. |
jkwak-work
reviewed
Apr 1, 2025
Comment on lines
+70
to
+76
| Our CI already tests with C++20-compatible compilers: | ||
|
|
||
| - GCC 13.0 | ||
| - Clang 15 | ||
| - MSVC 19.26 | ||
|
|
||
| This means we already don't test with older C++17-only compilers. |
Contributor
There was a problem hiding this comment.
Should we lower the compiler version on CI down to the minimum versions we can claim to support?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes shader-slang/slang#6581