Descriptor/file organizational changes#1570
Merged
stevenengler merged 2 commits intoshadow:mainfrom Aug 13, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
- Coverage 52.73% 52.67% -0.07%
==========================================
Files 141 141
Lines 21243 21237 -6
Branches 5375 5366 -9
==========================================
- Hits 11203 11186 -17
- Misses 7080 7088 +8
- Partials 2960 2963 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sporksmith
approved these changes
Aug 12, 2021
3dad450 to
f586116
Compare
f586116 to
b563fe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the
Arcto within thePosixFileenum, and added thePosixFileRefandPosixFileRefMuttypes that hold a borrowed reference to the inner object.This adds more boilerplate code, but is a lot more flexible when writing syscalls.
This is an updated version of #1083.