Fix a bug with UDP implicit bind after sendto()#3545
Merged
stevenengler merged 2 commits intoshadow:mainfrom Mar 31, 2025
Merged
Fix a bug with UDP implicit bind after sendto()#3545stevenengler merged 2 commits intoshadow:mainfrom
sendto()#3545stevenengler merged 2 commits intoshadow:mainfrom
Conversation
This test is currently failing in Shadow.
github-actions
bot
added
Component: Testing
This causes the test added in the previous commit to pass under Shadow.
stevenengler
force-pushed
the
fix-udp-sendto-implicit-bind
branch
from
357fb0f to
bd1a0ca
Compare
github-actions
bot
added
the
Component: Documentation
sporksmith
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a UDP socket that called
sendto()would be implicitly bound to an address on the same interface. So sending to 127.0.0.1 would cause the socket to be bound to 127.0.0.1. Sending to 1.2.3.4 would cause the socket to be bound to the public IP address of the host.This PR fixes the behaviour so that regardless of the address used with
sendto(), the socket will always be bound to 0.0.0.0.This, along with #3531, should fix #3526.