Skip to content

Comments

Skip empty plots if there's no data#104

Closed
stevenengler wants to merge 1 commit intoshadow:mainfrom
stevenengler:skip-empty-plots
Closed

Skip empty plots if there's no data#104
stevenengler wants to merge 1 commit intoshadow:mainfrom
stevenengler:skip-empty-plots

Conversation

@stevenengler
Copy link
Contributor

@stevenengler stevenengler commented May 5, 2023

If there's no data for the plot, this PR skips creating that plot.

Good:

  • for networks without onion services, it doesn't create 8 empty onion service plots

Bad:

  • if something isn't working correctly, you won't see the empty plot to indicate that there's an issue (but it will be logged)

@stevenengler stevenengler self-assigned this May 5, 2023
@stevenengler stevenengler deleted the skip-empty-plots branch May 9, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants