Fix bugs in #235 #238
Merged
Fix bugs in #235 #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mygod
reviewed
May 7, 2020
Contributor
Mygod
left a comment
Mygod
left a comment
There was a problem hiding this comment.
Something doesn't make sense to me yet, see detailed comments.
Contributor
Author
|
Oops, it seems I pushed to the wrong repo... |
Contributor
Author
|
@zonyitoo you may want to do a force push to redo my merge... |
Contributor
|
So I guess the real bug is flipping proxy/bypass list it seems. |
Contributor
Author
|
@Mygod Okay, I think you're right. |
Merged
Collaborator
|
WHAT happened... |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acl::check_ip_in_proxy_list.context::check_ip_in_proxy_listadd_to_reverse_lookup_cacheTested locally, all routes in Android client should work now.