Fix bugs in #235 #239
Merged
Fix bugs in #235 #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mygod
reviewed
May 7, 2020
Contributor
There was a problem hiding this comment.
Looks good to me. Although (completely unrelated to changes currently) maybe we should remove cache entries when adding cache, for example:
1.1.1.1is not proxied by default;domain.comis resolved to1.1.1.1and gets proxied, and this gets added to the cache;anotherdomain.comis also resolved to1.1.1.1and gets bypassed -- we should still update the cache.
Contributor
Author
Let's make this a future improvement, although this use case doesn't make sense to me... |
Contributor
|
It's an edge case rather than a use case to be honest XD (it offers better consistency rather than utility). |
zonyitoo
approved these changes
May 7, 2020
Collaborator
|
Actually I don't know why Android needs so many complicated modification :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in #238