Skip to content

[Libs] Ngs2#1604

Merged
georgemoralis merged 13 commits intoshadps4-emu:mainfrom
lzardy:main
Mar 26, 2025
Merged

[Libs] Ngs2#1604
georgemoralis merged 13 commits intoshadps4-emu:mainfrom
lzardy:main

Conversation

@lzardy
Copy link
Contributor

@lzardy lzardy commented Nov 27, 2024

  • Added all ngs2 related headers
  • Reworked ngs2_impl to be more accurate, including structs (with byte comments, need confirmation)

I can remove the .cpp or .h that are not used or empty if needed.

@bigol83
Copy link
Contributor

bigol83 commented Nov 28, 2024

Is this supposed to work yet? I tried with Resident Evil and it crashes when calling the module
shad_log.txt

[Lib.SysModule] <Error> sysmodule.cpp:sceSysmoduleLoadModule:47: (DUMMY) called module = ORBIS_SYSMODULE_NGS2

@kalaposfos13
Copy link
Member

First off, let me state that audio in GR2 is a bit broken, and needs a skipped assert to get ingame, so it's possible that the problem comes from that, and not your PR.

Without the Ngs2 sysmodule, GR2 does output any sound, and with that on, the audio is way too loud and loopy. Here's a video showcasing it.

As the game does not go ingame on the latest main yet, I merged this PR on my gr2-hacks branch to test it. It segfaults a few seconds into booting, with the following stack trace:
hostBufferInfo is NULL here:

hostBufferInfo->hostBuffer = NULL;

called from here:
result = SystemSetup(option, bufferInfo, 0, 0);

called from the game code.

I'll attach the log as well, with the last few lines manually copied over from the terminal, as those lines got printed out to there, but not in the log.

@georgemoralis
Copy link
Collaborator

that doesn't suppose to produce any sound , it is just a basic skeleton

@georgemoralis georgemoralis marked this pull request as ready for review March 26, 2025 16:41
@georgemoralis georgemoralis merged commit 3abe5b0 into shadps4-emu:main Mar 26, 2025
auser1337 pushed a commit to auser1337/shadPS4 that referenced this pull request Mar 27, 2025
* [libSceNgs2] Logging & Structs

* clang

* clang

* stdarg incl

* proper logs

* ngs2 latest

* [libSceNgs2] Logging & Structs

* clang

* latest

* fix includes

* clang

* clang

---------

Co-authored-by: microsoftv <6063922+microsoftv@users.noreply.github.com>
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request May 12, 2025
This reverts commit 9c37aa0.

Revert "[Libs] Ngs2 (shadps4-emu#1604)"

This reverts commit 3abe5b0.

Revert "New Crowdin updates (shadps4-emu#2679)"

This reverts commit 90b949b.

Revert "Show a dialog only if no game directories are set (shadps4-emu#2690)"

This reverts commit 69cb4d5.

Revert "libkernel: Filesystem code cleanup (shadps4-emu#2554)"

This reverts commit d820464.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants