remove borderWidth changes they were broken#52
Merged
shahen94 merged 2 commits intoshahen94:masterfrom Mar 30, 2017
Merged
Conversation
Owner
|
@jberends What's the reason that you remove it ? |
Contributor
Author
|
It is throwing an error. Try it yourself but it requires additional work to
handle overriding properties of the RCTView parent class. I really wasn't
expecting that and thought it would be identical to the changes made to
expose those thumbWidth handles.
…On Mar 29, 2017 12:46 AM, "Shahen Hovhannisyan" ***@***.***> wrote:
@jberends <https://github.com/JBerends> What's the reason that you remove
it ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkbvQ2CTVh82izShjebZepAGqVfyAvWks5rqfBGgaJpZM4MsP_a>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested and working again