Skip to content

Fix FOUC by moving stylesheets to head #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2025
Merged

Fix FOUC by moving stylesheets to head #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9b6d98
Fix FOUC by moving stylesheets to head and disabling auto_load_bundle
justin808 Oct 16, 2025
63fea2d
Fix FOUC using content_for to ensure proper pack tag ordering
justin808 Oct 16, 2025
e3b0b70
Attempt: Move append calls to head with yield for view-specific packs
justin808 Oct 16, 2025
5f7c02b
Align stimulus_layout with application layout (still has execution or…
justin808 Oct 16, 2025
4cc2aeb
Fix FOUC by rendering body first to collect appends, then head with p…
justin808 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
<% content_for :body_content do %>
<%= react_component "NavigationBarApp" %>

<div class="container mx-auto px-4 flex-grow">
<%= yield %>
</div>

<%= react_component "Footer" %>

<!-- This is a placeholder for ReactOnRails to know where to render the store props for
client side hydration -->
<%= redux_store_hydration_data %>
<% end %>
<!DOCTYPE html>
<html>
<head>
Expand All @@ -8,23 +21,12 @@
<%= append_stylesheet_pack_tag('stimulus-bundle') %>
<%= append_javascript_pack_tag('stimulus-bundle') %>
<%= append_javascript_pack_tag('stores-registration') %>
<%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
<%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>

<%= csrf_meta_tags %>
</head>
<body class="min-h-screen flex flex-col bg-sky-50 text-gray-700">
<%= react_component "NavigationBarApp" %>

<div class="container mx-auto px-4 flex-grow">
<%= yield %>
</div>

<%= react_component "Footer" %>

<%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
<%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>

<!-- This is a placeholder for ReactOnRails to know where to render the store props for
client side hydration -->
<%= redux_store_hydration_data %>
<%= yield :body_content %>
</body>
</html>
22 changes: 12 additions & 10 deletions app/views/layouts/stimulus_layout.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
<% content_for :body_content do %>
<%= react_component "NavigationBarApp" %>

<div class="container mx-auto px-4 flex-grow">
<%= yield %>
</div>

<%= react_component "Footer" %>
<% end %>
<!DOCTYPE html>
<html>
<head>
Expand All @@ -7,20 +16,13 @@

<%= append_stylesheet_pack_tag('stimulus-bundle') %>
<%= append_javascript_pack_tag('stimulus-bundle') %>
<%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
<%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>

<%= csrf_meta_tags %>
</head>
<body class="min-h-screen flex flex-col bg-sky-50 text-gray-700">
<%= react_component "NavigationBarApp" %>

<div class="container mx-auto px-4 flex-grow">
<%= yield %>
</div>

<%= react_component "Footer" %>

<%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
<%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>
<%= yield :body_content %>
</body>
</html>