Skip to content

Upadate README #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2015
Merged

Upadate README #98

merged 3 commits into from
Sep 28, 2015

Conversation

@szyablitsky
Copy link
Contributor

CI configuration

@szyablitsky
Upadate README
7955e19 
CI configuration
@szyablitsky
Copy link
Contributor Author

If we move away from Travis CI, then we lose info on proper CI configuration which now is only contained in .travis.yml

@alex35mil
Copy link
Member

After merge of #96 it should be:

npm install
cd client && npm run build

@szyablitsky
Update README.md
a6e0555 
fix for new build system
@szyablitsky
Copy link
Contributor Author

@alexfedoseev Fixed. Thanks!

@alex35mil
Copy link
Member

Thanks! 👍 I'll merge it after #96

@alex35mil
Copy link
Member

@szyablitsky #96 is merged.
Here is the final travis config: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/.travis.yml
Please make one more fix and I'll merge it to master. Thanks!

@szyablitsky
Copy link
Contributor Author

@alexfedoseev Done!

alex35mil added a commit that referenced this pull request Sep 28, 2015
@alex35mil
Merge pull request #98 from szyablitsky/readme-ci-section
88df62b 
Upadate README
@alex35mil alex35mil merged commit 88df62b into shakacode:master Sep 28, 2015
@alex35mil
Copy link
Member

@szyablitsky Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szyablitsky @alex35mil