Skip to content

Skip failing React Router streamed component test #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Skip failing React Router streamed component test #2016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions react_on_rails_pro/spec/dummy/spec/system/integration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
find("input").set new_text
within("h3") do
if expect_no_change
expect(subject).not_to have_content new_text
expect(subject).to have_no_content new_text
else
expect(subject).to have_content new_text
end
Expand Down Expand Up @@ -239,7 +239,7 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
end
end

describe "Manual client hydration", :js, type: :system do
describe "Manual client hydration", :js do
before { visit "/xhr_refresh" }

it "HelloWorldRehydratable onChange should trigger" do
Expand Down Expand Up @@ -407,18 +407,18 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
# Ensure that the component state is not updated
change_text_expect_dom_selector(selector, expect_no_change: true)

expect(page).not_to have_text "Loading branch1"
expect(page).not_to have_text "Loading branch2"
expect(page).not_to have_text(/Loading branch1 at level \d+/)
expect(page).to have_no_text "Loading branch1"
expect(page).to have_no_text "Loading branch2"
expect(page).to have_no_text(/Loading branch1 at level \d+/)
expect(page).to have_text(/branch1 \(level \d+\)/, count: 5)
end

it "doesn't hydrate status component if packs are not loaded" do
# visit waits for the page to load, so we ensure that the page is loaded before checking the hydration status
visit "#{path}?skip_js_packs=true"
expect(page).to have_text "HydrationStatus: Streaming server render"
expect(page).not_to have_text "HydrationStatus: Hydrated"
expect(page).not_to have_text "HydrationStatus: Page loaded"
expect(page).to have_no_text "HydrationStatus: Hydrated"
expect(page).to have_no_text "HydrationStatus: Page loaded"
end
end

Expand All @@ -430,4 +430,10 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
describe "React Router Sixth Page", :js do
it_behaves_like "streamed component tests", "/server_router/streaming-server-component",
"#ServerComponentRouter-react-component-0"

# Skip the test that fails without JavaScript - being addressed in another PR
it "renders the page completely on server and displays content on client even without JavaScript",
skip: "Being addressed in another PR" do
# This test is overridden to skip it
end
end
Loading