-
-
Notifications
You must be signed in to change notification settings - Fork 638
Improve concurrent streaming error handling and configuration #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justin808
wants to merge
46
commits into
master
Choose a base branch
from
justin808/stream-error-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+387
−18
Open
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
189524d
add concurrent_stream_drain flag (default false)
ihabadham 882e596
add and bundle async runtime dependency
ihabadham 79e903f
concurrent fiber draining via Async with single writer; add tracing l…
ihabadham 7257e85
make sequential draining robust to already finished fibers
ihabadham d5c2f4c
add default backpressure via Async::Semaphore and handle client disco…
ihabadham 0a4e29e
add controller streaming specs for sequential vs concurrent, ordering…
ihabadham 16747b5
add a test for backpressure
ihabadham c177b8f
refactor to correct rubocop offenses
ihabadham 454868d
fix NoMethodError caused by Array.bytesize
ihabadham 253badd
add concurrent_stream_queue_capacity (default 64) and use it in strea…
ihabadham 64e8045
add a comment explaining why semaphore.acquire is preferable to semap…
ihabadham 64c0d08
refactor(stream): use Async::Queue#close as a final single sentinel; …
ihabadham 833023a
refactor: propagate streaming errors instead of rescuing
ihabadham 541c23c
ci: correct rubocop offenses
ihabadham a4df6b6
add a simpler test for the concurrent stream_view_containing_react_co…
AbanoubGhadban fd7fbc7
refactor streaming tests to use pure mock approach
ihabadham 40e31dc
DRY the tests
ihabadham d5ca2a7
remove the concurrent_stream_drain config flag and always stream comp…
ihabadham 35ff5d5
remove debug logging
ihabadham 999fbf7
correct rubocop offenses
ihabadham 483c5f6
use async queue instead of ruby array at helper spec
AbanoubGhadban 05991d3
Revert "use async queue instead of ruby array at helper spec"
AbanoubGhadban 271af4b
Enhance helper spec to support Async::Queue for chunk processing
AbanoubGhadban fb3e8bb
Revert "Enhance helper spec to support Async::Queue for chunk process…
AbanoubGhadban b78a541
Refactor helper spec to utilize Async::Queue for improved chunk proce…
AbanoubGhadban ee1d716
Refactor configuration and streaming logic to use concurrent_componen…
AbanoubGhadban 7ca6d54
Refactor streaming logic to remove unnecessary error handling for imp…
AbanoubGhadban b554748
pass buffer_size to LimitedQueue as a positional argument because it …
ihabadham 13d94fe
ci: correct rubocop offenses
ihabadham 2fc8eb5
ci: avoid getting a rubocop error
ihabadham 4dcf700
update CHANGELOG.md
ihabadham 559d373
Update react_on_rails to 16.0.1.rc.4 to fix yanked version issue
ihabadham fc8cb3e
remove accidently pushed Gemfile.local.backup
ihabadham db4f479
git ignore .claude/
ihabadham d3a63bf
Fix ReactOnRails::PackerUtils.using_packer? compatibility with react_…
ihabadham ba65781
Remove redundant .claude/ entry from react_on_rails_pro/.gitignore
ihabadham bc19a1f
Add missing validation call for concurrent_component_streaming_buffer…
ihabadham ec1af96
Validate buffer size as Integer instead of Numeric
ihabadham 3e8e26a
Add test for client disconnect cleanup behavior
github-actions[bot] 62e2995
Revert "Add test for client disconnect cleanup behavior"
ihabadham 9b536a4
Improve concurrent streaming error handling and configuration
justin808 d1c9028
Fix test mocks to support stream.closed? checks
ihabadham 3de5cb5
Fix client disconnect test to properly simulate stream.closed?
ihabadham 056502a
Refactor: Move disconnect test to stream_spec.rb for better organization
ihabadham 1447fa7
Remove unused index variable from producer-consumer queue
ihabadham c470c12
Remove redundant buffer size validation method
ihabadham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.