Skip to content

Fix bin/dev --verbose option causing error #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2025
Merged

Fix bin/dev --verbose option causing error #2023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/react_on_rails/dev/server_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,11 @@ def show_help
puts help_troubleshooting
end

# rubocop:disable Metrics/AbcSize
def run_from_command_line(args = ARGV)
require "optparse"

options = { route: nil, rails_env: nil }
options = { route: nil, rails_env: nil, verbose: false }

OptionParser.new do |opts|
opts.banner = "Usage: dev [command] [options]"
Expand All @@ -160,6 +161,10 @@ def run_from_command_line(args = ARGV)
options[:rails_env] = env
end

opts.on("-v", "--verbose", "Enable verbose output for pack generation") do
options[:verbose] = true
end

opts.on("-h", "--help", "Prints this help") do
show_help
exit
Expand All @@ -172,21 +177,23 @@ def run_from_command_line(args = ARGV)
# Main execution
case command
when "production-assets", "prod"
start(:production_like, nil, verbose: false, route: options[:route], rails_env: options[:rails_env])
start(:production_like, nil, verbose: options[:verbose], route: options[:route],
rails_env: options[:rails_env])
when "static"
start(:static, "Procfile.dev-static-assets", verbose: false, route: options[:route])
start(:static, "Procfile.dev-static-assets", verbose: options[:verbose], route: options[:route])
when "kill"
kill_processes
when "help", "--help", "-h"
show_help
when "hmr", nil
start(:development, "Procfile.dev", verbose: false, route: options[:route])
start(:development, "Procfile.dev", verbose: options[:verbose], route: options[:route])
else
puts "Unknown argument: #{command}"
puts "Run 'dev help' for usage information"
exit 1
end
end
# rubocop:enable Metrics/AbcSize

private

Expand Down