Skip to content

Ensure CI runs on uncategorized changes #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

Ensure CI runs on uncategorized changes #2079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b066160
Ensure CI runs on uncategorized changes
justin808 Nov 21, 2025
5caded5
Improve ci-changes-detector documentation and clarity
justin808 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion script/ci-changes-detector
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ PRO_RUBY_CHANGED=false
PRO_RSPEC_CHANGED=false
PRO_JS_CHANGED=false
PRO_DUMMY_CHANGED=false
UNCATEGORIZED_CHANGED=false

# Analyze each changed file
while IFS= read -r file; do
Expand Down Expand Up @@ -133,7 +134,7 @@ while IFS= read -r file; do
LINT_CONFIG_CHANGED=true
;;

# Lint/format configuration
# React on Rails Pro lint/format configuration
react_on_rails_pro/.rubocop.yml|react_on_rails_pro/.eslintrc*|react_on_rails_pro/.prettierrc*|react_on_rails_pro/tsconfig.json|react_on_rails_pro/.editorconfig|.github/workflows/pro-lint.yml)
DOCS_ONLY=false
PRO_LINT_CONFIG_CHANGED=true
Expand All @@ -151,6 +152,14 @@ while IFS= read -r file; do
PRO_JS_CHANGED=true
PRO_DUMMY_CHANGED=true
;;

# Catch-all: any file not explicitly categorized above
# Philosophy: When in doubt, run everything to ensure safety
# This prevents new file types or directories from being silently ignored by CI
*)
DOCS_ONLY=false
UNCATEGORIZED_CHANGED=true
;;
esac
done <<< "$CHANGED_FILES"

Expand Down Expand Up @@ -219,6 +228,7 @@ echo "Changed file categories:"
[ "$PRO_DUMMY_CHANGED" = true ] && echo -e "${YELLOW} • React on Rails Pro Dummy app${NC}"
[ "$LINT_CONFIG_CHANGED" = true ] && echo -e "${YELLOW} • Lint/format configuration${NC}"
[ "$PRO_LINT_CONFIG_CHANGED" = true ] && echo -e "${YELLOW} • React on Rails Pro lint/format configuration${NC}"
[ "$UNCATEGORIZED_CHANGED" = true ] && echo -e "${YELLOW} • Uncategorized changes (running full suite for safety)${NC}"

echo ""
echo "Recommended CI jobs:"
Expand Down Expand Up @@ -265,6 +275,18 @@ if [ "$PRO_DUMMY_CHANGED" = true ] || [ "$PRO_RUBY_CHANGED" = true ] || [ "$PRO_
RUN_PRO_DUMMY_TESTS=true
fi

# If we encounter a change that isn't explicitly categorized, default to running everything
if [ "$UNCATEGORIZED_CHANGED" = true ]; then
RUN_LINT=true
RUN_RUBY_TESTS=true
RUN_JS_TESTS=true
RUN_DUMMY_TESTS=true
RUN_GENERATORS=true
RUN_PRO_LINT=true
RUN_PRO_TESTS=true
RUN_PRO_DUMMY_TESTS=true
fi

[ "$RUN_LINT" = true ] && echo " ✓ Lint (Ruby + JS)"
[ "$RUN_RUBY_TESTS" = true ] && echo " ✓ RSpec gem tests"
[ "$RUN_JS_TESTS" = true ] && echo " ✓ JS unit tests"
Expand Down
Loading