Skip to content

Sprite renderer support#13

Closed
indikman wants to merge 4 commits intoshamsdev:masterfrom
indikman:Sprite-Renderer-Support
Closed

Sprite renderer support#13
indikman wants to merge 4 commits intoshamsdev:masterfrom
indikman:Sprite-Renderer-Support

Conversation

@indikman
Copy link

Added a new RendererType
Added a new method (into) that requests a SpriteRenderer as a parameter
Added the default placeholder loading for the spriterender
Added the spite case for the ImageLoader Ienumerator

Example scene for sprite loader is added

indikman and others added 4 commits November 17, 2020 23:15
The sprites will replace the sprite field in the sprite renderer other than setting its texture
Added a new RendererType
Added a new method (into) that requests a SpriteRenderer as a parameter
Added the default placeholder loading for the spriterender
Added the spite case for the ImageLoader Ienumerator
Example scene for sprite loader is added
Copy link
Owner

@shamsdev shamsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @indikman, You commits contains lots of unnecessary file changes on main script. Code refactoring is not acceptable. Please review your changes and make it more clear.
Regards.

@Techie-Pi
Copy link
Contributor

Techie-Pi commented Aug 10, 2021

Because of this PR being almost 10 months old, I'm going to do the same as did with #25 (old #20).
That new PR is going to replace this one, I'll edit this comment when I create it

Superseded by #26

@shamsdev
Copy link
Owner

Thank you very much @indikman #26 has been merged.

@shamsdev shamsdev closed this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants