Skip to content

⚡ Optimize Field.to_bytes with b''.join #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaonianche merged 2 commits into from
Jan 29, 2026
Merged

⚡ Optimize Field.to_bytes with b''.join #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca45e80
Optimize Field.to_bytes using b''.join
google-labs-jules[bot] Jan 28, 2026
a5ddaad
Update fit_tool/field.py
shaonianche Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions fit_tool/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,9 +405,10 @@ def encoded_value_to_bytes(self, encoded_value, endian: Endian = Endian.LITTLE)
return bytes_buffer

def to_bytes(self, endian: Endian = Endian.LITTLE) -> bytes:
bytes_buffer = b''
for value in self.encoded_values:
bytes_buffer += self.encoded_value_to_bytes(value, endian=endian)
bytes_buffer = b''.join(
self.encoded_value_to_bytes(value, endian=endian)
for value in self.encoded_values
)

# sometimes subfields or strings can be less than the allocated field size,
# so we pad the buffer with 0's to meet the size requirement.
Expand Down
Loading