Skip to content

Adding sbd distance method and its test.#40

Merged
avilchess merged 3 commits intomasterfrom
feature/sbd
Dec 19, 2018
Merged

Adding sbd distance method and its test.#40
avilchess merged 3 commits intomasterfrom
feature/sbd

Conversation

@avilchess
Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

License

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2018

Codecov Report

Merging #40 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   94.45%   94.47%   +0.02%     
==========================================
  Files          13       13              
  Lines         847      851       +4     
==========================================
+ Hits          800      804       +4     
  Misses         47       47
Flag Coverage Δ
#Linux 93.18% <100%> (+0.03%) ⬆️
#MacOS 92.94% <100%> (+0.03%) ⬆️
#Windows 94.12% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
khiva/distances.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335a7ba...67083b0. Read the comment docs.

Copy link
Copy Markdown
Contributor

@otorreno otorreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

expected = np.array([0, 0, 0, 64, 0, 0, 256, 64, 0])
np.testing.assert_array_almost_equal(squared_euclidean_result, expected, decimal=1)


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this empty line

@avilchess avilchess merged commit cdaf8b8 into master Dec 19, 2018
@avilchess avilchess deleted the feature/sbd branch December 19, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants