Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 94.56% 94.56% +<.01%
==========================================
Files 14 14
Lines 864 865 +1
==========================================
+ Hits 817 818 +1
Misses 47 47
Continue to review full report at Codecov.
|
dcuestam
reviewed
Feb 27, 2019
Contributor
dcuestam
left a comment
dcuestam
left a comment
There was a problem hiding this comment.
Please, apply the PR feedback.
| :param tolerance: The error tolerance to stop the computation of the centroids. | ||
| :param max_iterations: The maximum number of iterations allowed. | ||
|
|
||
| :return: Array of centroids and Array of Labels. |
Contributor
There was a problem hiding this comment.
Tuple with a KHIVA array containing the centroids and a KHIVA array containing the labels. (Please be consistent with the upper cases..Labels)
| :param tolerance: The error tolerance to stop the computation of the centroids. | ||
| :param max_iterations: The maximum number of iterations allowed. | ||
|
|
||
| :return: Array of centroids and Array of Labels. |
Contributor
There was a problem hiding this comment.
Tuple with a KHIVA array containing the centroids and a KHIVA array containing the labels. (Please be consistent with the upper cases..Labels)
lsybarguen
approved these changes
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Description
Tests
Commits
License
Documentation