Change simplify() preserve_topology default to True (match the Geometry method)#1392
Conversation
Pull Request Test Coverage Report for Build 2365845189
💛 - Coveralls |
|
I think in the future, there is scope to allow more than two simplify methods, as there are multiple "simplify" algorithms out there (published or coded in some form under a liberal licence). Currently, the |
|
@mwtoews that's a good point (eg GEOS 3.11 will have a PolygonHullSimplify method, so we can (in another issue) start discussing whether to expose this under Regardless of that, I think we still want to switch the default anyway (and we need to keep the existing keyword for some time for backwards compatibility), and so this PR should still be fine as is for now? |
mwtoews
left a comment
There was a problem hiding this comment.
Looks good. We can discuss changes to support more than two algorithms later.
xref #1276
The Geometry class'
simplify()method has a default ofpreserve_topology=True, while the vectorized function from pygeos was usingTrue. But I think we have been thinking in the past we should probably move toTrueanyway (to return valid geometries by default, eg pygeos/pygeos#233 (comment)), and that also ensures that the function and geometry class method use a consistent default.