New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for source location #92

Closed
gorkem opened this Issue Nov 13, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@gorkem

gorkem commented Nov 13, 2015

SourceLocation is part of the shift-ast specification but it is not implemented for the Node interface. Implementation probably requires Node interface to become an abstract class implementation but since Node interface is referenced from all the AST model classes, it is best to build this change to model generator.

@ariya

This comment has been minimized.

Show comment
Hide comment
@ariya

ariya Nov 19, 2015

@ikarienator Do we have this in our roadmap?

ariya commented Nov 19, 2015

@ikarienator Do we have this in our roadmap?

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Nov 19, 2015

Member

Yes, we do, but we're not sure yet how to best implement it.

Member

michaelficarra commented Nov 19, 2015

Yes, we do, but we're not sure yet how to best implement it.

@steindani

This comment has been minimized.

Show comment
Hide comment
@steindani

steindani Feb 17, 2016

Contributor

I'd also like to access the location of the nodes. Since the project targets Java 8, what do you think about using a common HashMap storage for node-location pairs and a getter method implemented in the Node interface itself using a default method? This does not need such an invasive modification and when a change may occur, the interface could stay the same?

Contributor

steindani commented Feb 17, 2016

I'd also like to access the location of the nodes. Since the project targets Java 8, what do you think about using a common HashMap storage for node-location pairs and a getter method implemented in the Node interface itself using a default method? This does not need such an invasive modification and when a change may occur, the interface could stay the same?

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Mar 9, 2016

Member

This was fixed by #101.

Member

michaelficarra commented Mar 9, 2016

This was fixed by #101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment