Add support for source location #92

Closed
gorkem opened this Issue Nov 13, 2015 · 4 comments

Projects

None yet

4 participants

@gorkem
gorkem commented Nov 13, 2015

SourceLocation is part of the shift-ast specification but it is not implemented for the Node interface. Implementation probably requires Node interface to become an abstract class implementation but since Node interface is referenced from all the AST model classes, it is best to build this change to model generator.

@ariya
Member
ariya commented Nov 19, 2015

@ikarienator Do we have this in our roadmap?

@michaelficarra
Member

Yes, we do, but we're not sure yet how to best implement it.

@steindani
Contributor

I'd also like to access the location of the nodes. Since the project targets Java 8, what do you think about using a common HashMap storage for node-location pairs and a getter method implemented in the Node interface itself using a default method? This does not need such an invasive modification and when a change may occur, the interface could stay the same?

@michaelficarra
Member

This was fixed by #101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment