This repository was archived by the owner on Apr 11, 2023. It is now read-only.
feat: utxo chain adapter refactor #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xean
commented
Mar 3, 2022
0xean
commented
Mar 3, 2022
0xean
commented
Mar 3, 2022
0xean
changed the title
0xdef1cafe
reviewed
Mar 3, 2022
0xdef1cafe
reviewed
Mar 3, 2022
0xdef1cafe
reviewed
Mar 3, 2022
0xean
force-pushed
the
feature/utxo-chain-adapter
branch
from
35ce6c6 to
1e7b5df
Compare
Contributor
Author
|
alright, this should be good to go now, all conflicts have been resolved. |
Contributor
Author
|
argh, one sec and then should be ready for review. |
Contributor
Author
|
alright actually ready now. |
kaladinlight
reviewed
Mar 8, 2022
kaladinlight
reviewed
Mar 8, 2022
kaladinlight
approved these changes
Mar 8, 2022
Contributor
kaladinlight
left a comment
kaladinlight
left a comment
There was a problem hiding this comment.
A couple follow up remarks, but generally looks good to go as a starting place to start iterating on. Thanks!
asamere
reviewed
Mar 8, 2022
kaladinlight
approved these changes
Mar 8, 2022
asamere
approved these changes
Mar 8, 2022
Contributor
asamere
left a comment
asamere
left a comment
There was a problem hiding this comment.
Regarding "providers" we should keep in mind eventually/ultimately backend providers will be dynamic, with multiple potential backends for each chain. These could come from an ETH contract, IPFS, etc but will change as operators and infra availability fluctuates.
0xean
force-pushed
the
feature/utxo-chain-adapter
branch
from
4cde6bd to
8ee105e
Compare
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
# [@shapeshiftoss/chain-adapters-v2.2.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/chain-adapters-v2.1.0...@shapeshiftoss/chain-adapters-v2.2.0) (2022-03-08) ### Features * utxo chain adapter refactor ([#411](#411)) ([c6d1b31](c6d1b31))
Member
|
🎉 This PR is included in version @shapeshiftoss/chain-adapters-v2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves much of the BitcoinChainAdapter logic in a UTXOBaseAdapter class that can be re-used for future UTXO's.
It also includes some minor updates to the README
Have a few questions to run down before we merge and will add those as comments momentarily.
Currently, all existing tests pass, but have not done any additional testing past that.
Closes #125