Skip to content

feat: halt thorchain lp deposit/withdraw#11220

Merged
0xApotheosis merged 1 commit intodevelopfrom
feat_thorchain_lp_disable_deposit_withdraw
Nov 27, 2025
Merged

feat: halt thorchain lp deposit/withdraw#11220
0xApotheosis merged 1 commit intodevelopfrom
feat_thorchain_lp_disable_deposit_withdraw

Conversation

@gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Nov 27, 2025

Description

See https://discord.com/channels/838986635756044328/1443630644034011278:

Devs are pausing LP over the holiday weekend along with churn to stop the mimir from being reset to investigate a potential issue after we’re back from break

The easy way to halt - will follow-up with a PR introspecting the mimir instead

Issue (if applicable)

closes N/A

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

  • Should be unable to interact with LP deposits/withdraws for the time being

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

Screenshot 2025-11-27 at 19 59 38

Summary by CodeRabbit

  • Chores
    • Disabled ThornChain LP deposit and withdraw features.

✏️ Tip: You can customize this high-level summary in your review settings.

@gomesalexandre gomesalexandre requested a review from a team as a code owner November 27, 2025 19:01
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

📝 Walkthrough

Walkthrough

Two feature flags in the environment configuration were disabled: VITE_FEATURE_THORCHAIN_LP_DEPOSIT and VITE_FEATURE_THORCHAIN_LP_WITHDRAW were changed from true to false, disabling Thorchain LP deposit and withdraw functionality.

Changes

Cohort / File(s) Summary
Environment Configuration
.env
Disabled VITE_FEATURE_THORCHAIN_LP_DEPOSIT and VITE_FEATURE_THORCHAIN_LP_WITHDRAW feature flags by changing values from true to false

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Verify the feature flag changes align with intended product decisions for disabling Thorchain LP operations

Possibly related PRs

  • shapeshift/web#10070: Related Thorchain LP deposit enablement changes—that PR removes a RUJI-specific override in the deposit enablement hook while this PR disables the feature flags globally.

Suggested reviewers

  • 0xApotheosis
  • kaladinlight

Poem

Hippity-hop! Through configs I bound,
Two flags flipped with gentle sound,
THORCHAIN's deposit, withdraw they rest,
Disabled features serve us best! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: disabling thorchain LP deposit and withdraw features via feature flags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat_thorchain_lp_disable_deposit_withdraw

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm, get in.

As noted gomes we should add a way to check the mimir instead, but this is totally fine for now!

@0xApotheosis 0xApotheosis merged commit aae4c99 into develop Nov 27, 2025
4 checks passed
@0xApotheosis 0xApotheosis deleted the feat_thorchain_lp_disable_deposit_withdraw branch November 27, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants