feat: enable trezor support for zcash#11338
Merged
gomesalexandre merged 15 commits intodevelopfrom Dec 10, 2025
Merged
Conversation
Add comprehensive implementation plan documenting: - Current broadcast error with Trezor wallet - Root cause analysis (missing Trezor Connect parameters) - Required hdwallet-trezor changes - Testing strategy including verdaccio pipeline - Technical background on Zcash versioning 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Warning Rate limit exceeded@gomesalexandre has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 7 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gomesalexandre
changed the title
Clarify that web changes are NOT yet implemented: - PR #11327 reverted Trezor support to native-only - Need to add isTrezorHDWallet checks in two files - Update checklist to reflect pending web work 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add Trezor wallet support for Zcash by updating wallet support checks: - Import isTrezorHDWallet helper - Allow Trezor alongside native wallet for Zcash transactions Files modified: - useWalletSupportsChain.ts: Add Trezor check for zecChainId - portfolioSlice utils: Add Trezor check for zecChainId Note: Requires hdwallet-trezor updates to pass Zcash-specific transaction parameters (versionGroupId, consensusBranchId) to Trezor Connect. See ZCASH_TREZOR_IMPLEMENTATION.md for details. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Bump all hdwallet packages to 1.62.26-zcash-trezor.0 (local verdaccio) - Update publish pipeline skill with verification step for all package.json files - Configure yarn to use local verdaccio registry 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit dfb64d7.
gomesalexandre
changed the title
NeOMakinG
approved these changes
Dec 10, 2025
Collaborator
NeOMakinG
left a comment
NeOMakinG
left a comment
There was a problem hiding this comment.
Derivation is fine, signing is fine, I guess we can give this a go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue (if applicable)
closes shapeshift/hdwallet#761
Risk
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/652f849a-4cc8-4f1f-b1da-7d89a195eeb4