Skip to content

chore: remove onramper console spew#11363

Merged
gomesalexandre merged 1 commit intodevelopfrom
fix-onramper-spew
Dec 11, 2025
Merged

chore: remove onramper console spew#11363
gomesalexandre merged 1 commit intodevelopfrom
fix-onramper-spew

Conversation

@0xApotheosis
Copy link
Copy Markdown
Member

@0xApotheosis 0xApotheosis commented Dec 11, 2025

Description

Remove onramper spew.

Issue (if applicable)

N/A, I'm just tired of seeing it and it adds no value.

Risk

Minimal

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

We should no longer see this in the console:

Screenshot 2025-12-11 at 4 01 26 pm

Engineering

👆

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

👆

Screenshots (if applicable)

See above.


Note

Stops logging a console warning for unsupported OnRamper networks, returning undefined silently.

  • OnRamper utils:
    • Remove console.warn on unsupported network in src/components/Modals/FiatRamps/fiatRampProviders/onramper/utils.ts within findAssetIdByOnramperCrypto, keeping the undefined return without logging.

Written by Cursor Bugbot for commit 7213ea1. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Bug Fixes
    • Eliminated unnecessary console warnings when using the Onramper fiat ramp feature.

✏️ Tip: You can customize this high-level summary in your review settings.

@0xApotheosis 0xApotheosis requested a review from a team as a code owner December 11, 2025 05:04
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 11, 2025

📝 Walkthrough

Walkthrough

A runtime warning removed from the Onramper utilities module. When the network cannot be resolved, the function now returns undefined silently instead of logging a console warning.

Changes

Cohort / File(s) Change Summary
Onramper utility warning removal
src/components/Modals/FiatRamps/fiatRampProviders/onramper/utils.ts
Removed console.warn when getChainIdFromOnramperNetwork returns falsy; function now returns undefined without logging

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file, straightforward removal of a logging statement
  • No logic changes or control flow modifications
  • No impact to other components

Poem

🐰 A warning worn away like whiskers in the breeze,
No console cries when networks fail to please,
Silent returns now grace the code with ease—
One less log to clutter up our trees! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove onramper console spew' directly and accurately describes the main change: removing console output/warnings from the Onramper integration, matching the code summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-onramper-spew

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 24f0049 and 7213ea1.

📒 Files selected for processing (1)
  • src/components/Modals/FiatRamps/fiatRampProviders/onramper/utils.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • src/components/Modals/FiatRamps/fiatRampProviders/onramper/utils.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cursor Bugbot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spew is bye bye! 👋🏽

Image

@gomesalexandre gomesalexandre merged commit c4a5e9a into develop Dec 11, 2025
5 checks passed
@gomesalexandre gomesalexandre deleted the fix-onramper-spew branch December 11, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants