chore: just the rfox text changes#11852
Conversation
📝 WalkthroughWalkthroughEnglish translation strings updated to replace RUNE/THORChain-specific reward language with USDC/revenue-based wording across staking, unstaking, connect, and FOX token pages; added cooldown and multiple-unstaking entries. No code or runtime logic changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/assets/translations/en/main.json`:
- Line 2389: Update the translation string with key "connect.body" to replace
the incorrect phrase "RUNE rewards" with "USDC rewards" (or whichever reward
token the rest of the FAQ uses) so it matches the other keys ("why", "stake",
"unstake"); verify the edited sentence in the "body" value mentions USDC as the
distributed reward and keep the rest of the wording intact for grammar and
clarity.
Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/assets/translations/en/main.json`:
- Line 2373: The translation strings are inconsistent: "why.body" uses "per
epoch" while "stake.body" says "per block"; update the "stake.body" value in
src/assets/translations/en/main.json (key "stake.body") to use the same
terminology as "why.body" (replace "USDC rewards per block" with "USDC rewards
per epoch") so both messages are consistent.
Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/assets/translations/en/main.json (1)
2389-2396:⚠️ Potential issue | 🔴 CriticalThe new FAQ translation keys are added but not consumed in the codebase.
The keys
RFOX.faq.cooldownandRFOX.faq.multipleUnstakingare present insrc/assets/translations/en/main.json, but verification found zero references to these keys anywhere in the codebase. According to the coding guidelines, translations must be both (1) added toen/main.jsonAND (2) consumed viatranslate('key')— missing either step results in untranslated strings.To complete this work:
- Create an RFOX FAQ component (e.g.,
src/pages/RFOX/components/Faq.tsx) similar to the pattern used inThorChainLP/components/Faq.tsxandLending/Pool/components/Faq.tsx- Display all RFOX FAQ entries using the
translate()function with theRFOX.faq.*keys- Ensure the FAQ component is rendered on the appropriate RFOX page
This reverts commit 86d5d9b.
This reverts commit 86d5d9b.
Description
Simply changing the text on rfox to effect the new change to the program.
Issue (if applicable)
related to #11828 tho the simulator and the warning modal needs a different PR.
Risk
Low
Testing
Same as #11829 but just the text, even edited the FAQ we don't use for posterity or if we bring it back.
Engineering
Did a local coderabbit review so a quick pass can't hurt.
Operations
Screenshots (if applicable)
Summary by CodeRabbit