Skip to content

chore: just the rfox text changes#11852

Merged
kaladinlight merged 4 commits intodevelopfrom
rfox-text
Feb 13, 2026
Merged

chore: just the rfox text changes#11852
kaladinlight merged 4 commits intodevelopfrom
rfox-text

Conversation

@twblack88
Copy link
Contributor

@twblack88 twblack88 commented Feb 12, 2026

Description

Simply changing the text on rfox to effect the new change to the program.

Issue (if applicable)

related to #11828 tho the simulator and the warning modal needs a different PR.

Risk

Low

Testing

Same as #11829 but just the text, even edited the FAQ we don't use for posterity or if we bring it back.

Engineering

Did a local coderabbit review so a quick pass can't hurt.

Operations

Screenshots (if applicable)

Screenshot 2026-02-12 at 11 22 39 AM

Summary by CodeRabbit

  • Documentation
    • Updated reward and revenue language to reference USDC-based distributions and platform-wide revenues instead of prior RUNE-focused wording.
    • Revised FOX token page and connect guidance to reflect revenue conversion and distribution changes while preserving governance framing.
    • Added cooldown and unstaking explanations (28-day cadence) and notes on multiple unstaking amounts with separate cooldowns.
    • Standardized asset-denomination phrasing and made minor FOX-related wording adjustments.

@twblack88 twblack88 requested a review from a team as a code owner February 12, 2026 19:25
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

English translation strings updated to replace RUNE/THORChain-specific reward language with USDC/revenue-based wording across staking, unstaking, connect, and FOX token pages; added cooldown and multiple-unstaking entries. No code or runtime logic changes.

Changes

Cohort / File(s) Summary
Translations (single file)
src/assets/translations/en/main.json
Replaced RUNE/THORChain reward/emission phrasing with USDC/revenue-based language across "Why stake FOX", "How to stake FOX", "Unstake FOX", "Connect", and FOX token pages; added cooldown and multipleUnstaking entries; standardized some asset-denomination wording.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • gomesalexandre
  • 0xApotheosis

Poem

🐰 I hopped through keys and lines today,
I nudged old RUNE to USDC way,
Cooldowns counted, entries neat,
Words now hum a steadier beat,
Little whiskers cheer the change—hip hooray!

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using non-descriptive language ('just the rfox text changes') that doesn't clearly convey what aspect of rFOX was changed or why. Revise the title to be more specific about the change, such as 'chore: update rFOX staking text to reflect USDC-based rewards' or similar, to clarify the nature of the text changes for future reference.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rfox-text

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/assets/translations/en/main.json`:
- Line 2389: Update the translation string with key "connect.body" to replace
the incorrect phrase "RUNE rewards" with "USDC rewards" (or whichever reward
token the rest of the FAQ uses) so it matches the other keys ("why", "stake",
"unstake"); verify the edited sentence in the "body" value mentions USDC as the
distributed reward and keep the rest of the wording intact for grammar and
clarity.

Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/assets/translations/en/main.json`:
- Line 2373: The translation strings are inconsistent: "why.body" uses "per
epoch" while "stake.body" says "per block"; update the "stake.body" value in
src/assets/translations/en/main.json (key "stake.body") to use the same
terminology as "why.body" (replace "USDC rewards per block" with "USDC rewards
per epoch") so both messages are consistent.

Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
@kaladinlight kaladinlight enabled auto-merge (squash) February 13, 2026 21:00
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/assets/translations/en/main.json (1)

2389-2396: ⚠️ Potential issue | 🔴 Critical

The new FAQ translation keys are added but not consumed in the codebase.

The keys RFOX.faq.cooldown and RFOX.faq.multipleUnstaking are present in src/assets/translations/en/main.json, but verification found zero references to these keys anywhere in the codebase. According to the coding guidelines, translations must be both (1) added to en/main.json AND (2) consumed via translate('key') — missing either step results in untranslated strings.

To complete this work:

  • Create an RFOX FAQ component (e.g., src/pages/RFOX/components/Faq.tsx) similar to the pattern used in ThorChainLP/components/Faq.tsx and Lending/Pool/components/Faq.tsx
  • Display all RFOX FAQ entries using the translate() function with the RFOX.faq.* keys
  • Ensure the FAQ component is rendered on the appropriate RFOX page

@kaladinlight kaladinlight merged commit 86d5d9b into develop Feb 13, 2026
4 checks passed
@kaladinlight kaladinlight deleted the rfox-text branch February 13, 2026 21:13
firebomb1 added a commit to shapeshift-globalization/web that referenced this pull request Feb 16, 2026
firebomb1 added a commit to shapeshift-globalization/web that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants