feat: bump affiliate fees to 60 bps#11920
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe pull request updates the default affiliate fee basis points from 55 to 60 across configuration constants and test expectations. Changes are applied consistently to config files, mock API responses, and test assertions with no modifications to logic or control flow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
For posterity, this is following DFC's vote to increase fees here: https://discord.com/channels/554694662431178782/920449863408287855/1460829229561151790 And within their mission granted by SCP-170. |
Description
Does what it says on the box.
DEFAULT_FEE_BPSand the public API'sDEFAULT_AFFILIATE_BPSnow surface 60 so every swapper, rate, and quote consumer sees the same bump.Issue
closes #11919
Risk
Low - static constants only, no protocol logic touched.
Testing
Engineering
60Operations
Screenshots (if applicable)
n/a
Summary by CodeRabbit