Skip to content

feat: bump affiliate fees to 60 bps#11920

Merged
0xApotheosis merged 1 commit intoshapeshift:developfrom
gomes-bot:fix/affiliate-bps-60
Feb 18, 2026
Merged

feat: bump affiliate fees to 60 bps#11920
0xApotheosis merged 1 commit intoshapeshift:developfrom
gomes-bot:fix/affiliate-bps-60

Conversation

@gomes-bot
Copy link
Contributor

@gomes-bot gomes-bot commented Feb 17, 2026

Description

Does what it says on the box. DEFAULT_FEE_BPS and the public API's DEFAULT_AFFILIATE_BPS now surface 60 so every swapper, rate, and quote consumer sees the same bump.

Issue

closes #11919

Risk

Low - static constants only, no protocol logic touched.

Testing

Engineering

  • Request any swap quote (web or public API) and confirm affiliate bps surfaces as 60

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

n/a

Summary by CodeRabbit

  • Chores
    • Default affiliate fee rates have been increased from 55 to 60 basis points across the platform. This adjustment impacts all commission and fee calculations throughout the system. Platform configuration, mock API responses, and automated tests have been synchronized to reflect the new rates and maintain consistent behavior.

@gomes-bot gomes-bot requested a review from a team as a code owner February 17, 2026 16:29
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The pull request updates the default affiliate fee basis points from 55 to 60 across configuration constants and test expectations. Changes are applied consistently to config files, mock API responses, and test assertions with no modifications to logic or control flow.

Changes

Cohort / File(s) Summary
Configuration Constants
packages/public-api/src/config.ts, src/lib/fees/constant.ts
Updated DEFAULT_AFFILIATE_BPS and DEFAULT_FEE_BPS exported constants from '55' to '60'.
Mock Responses & Tests
packages/public-api/src/server-standalone.ts, src/lib/fees/utils.test.ts
Updated affiliateBps values in mock API responses (3 entries) and test expectation from '55' to '60'.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • gomesalexandre
  • premiumjibles

Poem

🐰 From fifty-five to sixty hops we bound,
Fee basis points leaping all around,
The DFC voted, unanimous and clear,
More revenue blooms in the newborn year! 📈

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: bump affiliate fees to 60 bps' accurately and concisely summarizes the main change: updating affiliate fee constants from 55 to 60 basis points across the codebase.
Linked Issues check ✅ Passed The pull request successfully addresses issue #11919 by updating DEFAULT_FEE_BPS and DEFAULT_AFFILIATE_BPS constants to 60 bps across all relevant files and test expectations.
Out of Scope Changes check ✅ Passed All changes are directly related to the objective of bumping affiliate fees to 60 bps; no unrelated or out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@firebomb1
Copy link
Contributor

For posterity, this is following DFC's vote to increase fees here: https://discord.com/channels/554694662431178782/920449863408287855/1460829229561151790

And within their mission granted by SCP-170.

Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm

@0xApotheosis 0xApotheosis merged commit c032c50 into shapeshift:develop Feb 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fee BPS to 60

3 participants