fix: limit orders crashing

[NeOMakinG]

Description

Limit orders are not working anymore because Cowswap changed something in their proxy, its not accepting trailing slash anymore, updating the URLs fixes the thing!

Issue (if applicable)

closes #11966

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

Operations

• 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Summary by CodeRabbit

• Bug Fixes
  • Updated CowSwap API endpoints for quote requests and order submissions to improve service compatibility and stability.

[gomesalexandre]

lolwtf @ this

https://jam.dev/c/2b8ec353-520f-4ebf-9eaf-bb156c1994e3

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

Removes trailing slashes from CowSwap API endpoint URLs across the swapper module and limit order API, changing paths from /api/v1/quote/ and /api/v1/orders/ to their non-trailing-slash equivalents. Updates corresponding test expectations to match the new endpoint format.

Changes

Cohort / File(s)	Summary
CowSwapper Endpoints packages/swapper/src/swappers/CowSwapper/CowSwapper.ts, packages/swapper/src/swappers/CowSwapper/getCowSwapTradeQuote/getCowSwapTradeQuote.ts, packages/swapper/src/swappers/CowSwapper/getCowSwapTradeRate/getCowSwapTradeRate.ts	Removed trailing slashes from order submission and quote request endpoints.
CowSwapper Tests packages/swapper/src/swappers/CowSwapper/getCowSwapTradeQuote/getCowSwapTradeQuote.test.ts	Updated test mock expectations to use non-trailing-slash endpoint URLs.
Limit Order API src/state/apis/limit-orders/limitOrderApi.ts	Removed trailing slashes from quote and order request endpoint paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

• 0xApotheosis
• NeOMakinG

Poem

🐰 A trailing slash caused quite the fright,
The limit orders took their flight,
But snip! One slash removed with care,
Now endpoints work without despair! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix: limit orders crashing' is vague about what was changed; it describes the problem but not the solution (removing trailing slashes from URLs).	Consider updating the title to be more specific about the fix, such as 'fix: remove trailing slashes from CowSwap API endpoints' to clarify what was actually changed.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	The PR successfully addresses the linked issue #11966 by removing trailing slashes from CowSwap API endpoints, which fixes the broken limit order functionality caused by Cowswap proxy changes.
Out of Scope Changes check	✅ Passed	All changes are scoped to removing trailing slashes from CowSwap API endpoints across five files related to limit orders and quote functionality, directly addressing the root cause of the issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch limit-order-crash

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}