feat: thorchain solana lp integration

[gomesalexandre]

Description

Adds SOL.SOL LP (add/remove liquidity) support to the THORChain LP page. Builds on #12036 (swapper integration).

What this enables:

• Users can add liquidity to the SOL.SOL THORChain pool (asym or sym)
• Users can remove liquidity from the SOL.SOL position
• Fee estimation includes the SPL Memo Program compute budget for accurate gas

How it works:

THORChain LP transactions are native SOL sends to vault + SPL Memo Program instruction. The useSendThorTx hook handles all LP tx execution via the 'Send' path. Two surgical changes:

1. getThorchainTransactionType — add solanaChainId to the 'Send' return condition (Solana routes the same way as UTXO/Tron: direct vault send)

2. Send/utils.ts — add Memo Program instruction support to both:

   • estimateFees Solana case: when memo is present, builds a TransactionInstruction (web3.js) and includes it in getFeeData so compute budget reflects the memo instruction
   • handleSend Solana case: when memo is present, builds a SolanaTxInstruction (hdwallet) and includes it in buildSendTransaction.chainSpecific.instructions

No UI changes needed — Solana already appears in the pool list, walletSupportsChain already handles it.

Issue (if applicable)

closes #12035

Risk

Low — Solana LP path is additive; only changes are in well-contained Send utils and one helper function. Existing Solana send flows (Jupiter, direct SOL/SPL sends) unaffected since memo instruction is only added when memo is non-null.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

THORChain SOL LP add/remove transactions. Inbound vault: GWYXY7c6SVMkuhmDq2LT1Hj6qGkDFCqmdZWJdCeHUgEN.

Testing

Engineering

Must merge #12036 first (this PR targets that branch).

# dev test (connect a Phantom/Backpack wallet with SOL)
# 1. Navigate to Earn -> THORChain LP
# 2. Confirm SOL.SOL pool appears in available pools
# 3. Click Add Liquidity for SOL.SOL
# 4. Enter SOL amount (asym)
# 5. Verify fee estimate is non-zero and includes compute budget
# 6. Confirm -> verify tx goes to vault GWYXY7c6SVMkuhmDq2LT1Hj6qGkDFCqmdZWJdCeHUgEN with +:SOL.SOL memo
# 7. Remove liquidity -> verify tx goes to vault with -:SOL.SOL:<bps> memo

Manual test checklist:

• SOL.SOL pool appears in available pools
• Asym add liquidity (SOL side): fee estimate non-null, tx has Memo instruction
• Sym add liquidity (SOL + RUNE): SOL tx has Memo instruction, RUNE tx uses MsgDeposit
• Remove liquidity: tx has Memo instruction with -:SOL.SOL:
• Existing Solana Jupiter swaps unaffected (no memo = no instruction)
• Existing UTXO/Tron LP flows unaffected

Operations

• 🏁 My feature is behind a flag and doesn't require operations testing (yet)

SOL.SOL pool is live. Operations can test add/remove liquidity with a small SOL amount.

Screenshots (if applicable)

Summary by CodeRabbit

• New Features

  • Added Solana transaction memo support for fee estimation and sending workflows
  • Improved Solana transaction type recognition in Thorchain swap processing

• Tests

  • Added test identifiers to ThorChain liquidity provider interface components for enhanced test coverage

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR adds Solana native token support to THORChain LP operations by implementing memo-based transaction instructions, extends transaction type detection to include Solana chains, refines asset lookups with case-insensitive mapping, and adds test identifiers to LP UI components.

Changes

Cohort / File(s)	Summary
Asset Lookup Optimization packages/swapper/src/swappers/ThorchainSwapper/utils/poolAssetHelpers/poolAssetHelpers.ts	Introduces lower-cased lookup map for case-insensitive asset ID resolution; converts assetIdToThorPoolAssetIdMap to explicit Record typing and updates lookup logic to use toLowerCase().
Solana Constants packages/swapper/src/thorchain-utils/solana/constants.ts	New module exports MEMO_PROGRAM_ID constant referencing Solana Memo Program v2 address.
Solana Transaction Memo Support src/components/Modals/Send/utils.ts	Adds memo instruction handling for Solana fee estimation and transaction building; constructs memoInstruction when memo is present and adjusts compute budget logic accordingly for both estimation and actual SOL transfers.
THORChain Transaction Type Detection src/lib/utils/thorchain/index.ts	Extends getThorchainTransactionType to classify Solana transactions as Send path alongside UTXO, Cosmos, and Tron chains.
LP UI Testing Enhancements src/pages/ThorChainLP/components/AddLiquidityInput.tsx, src/pages/ThorChainLP/components/LpType.tsx	Adds data-testid attributes to deposit button and LP type radio selectors; wires data-testid prop through TypeRadio component to root label element for improved test coverage.

Sequence Diagram

sequenceDiagram
    participant User as User/Client
    participant FeeEst as Fee Estimator
    participant TxBuilder as Solana Tx Builder
    participant MemoProg as Memo Program
    participant Vault as THORChain Vault
    
    User->>FeeEst: Request LP fee estimate with memo
    alt Memo present
        FeeEst->>TxBuilder: Build memoInstruction from memo
        TxBuilder->>TxBuilder: Create Memo Program instruction
    end
    FeeEst->>FeeEst: Adjust estimationInstructions with memo
    FeeEst-->>User: Return fee estimate
    
    User->>TxBuilder: Send LP transaction (SOL + memo)
    TxBuilder->>TxBuilder: Build memoInstruction
    TxBuilder->>TxBuilder: Determine compute budget need
    alt Should add compute budget
        TxBuilder->>TxBuilder: Set computeUnitLimit & computeUnitPrice
        TxBuilder->>TxBuilder: Add memo to chainSpecific instructions
    end
    TxBuilder->>MemoProg: Include Memo Program instruction
    MemoProg-->>Vault: Memo data (+:SOL.SOL for add liquidity)
    TxBuilder-->>Vault: Send native SOL
    Vault-->>User: LP position confirmed

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰✨ A Solana seed takes root so deep,
With memos whispered, promises to keep,
The vault receives our gleaming SOL,
Liquidity pooled, transactions whole—
THORChain bridges, test IDs aligned,
A rabbit's leap to riches refined! 🌙💫

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: thorchain solana lp integration' accurately describes the main objective of adding Solana support for THORChain LP add/remove liquidity, which is the primary focus of the changeset.
Linked Issues check	✅ Passed	All key objectives from #12035 are met: Solana added to getThorchainTransactionType for routing, Memo Program instruction handling integrated into Send/utils.ts fee estimation and execution, and data-testids added for LP UI testing.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to the linked issue objectives: Thorchain Solana routing, memo instruction support, and LP UI testing identifiers; no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/thorchain-solana-lp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[NeOMakinG]

Code Review ✅

Reviewed by: QABot (automated)

Summary

Clean, focused PR adding THORChain Solana LP support. Changes are minimal and well-targeted.

Changes Reviewed:

1. poolAssetHelpers.ts - Case-insensitive asset ID mapping for Solana base58 addresses ✅
2. solana/constants.ts - New Memo Program ID constant, well-documented ✅
3. Send/utils.ts - Memo instruction support for fee estimation and transactions ✅
4. thorchain/index.ts - Adds Solana to Send transaction type ✅

Assessment:

• Type safety: ✅ Proper imports and usage (SolanaTxInstruction, PublicKey, etc.)
• Error handling: ✅ Follows existing patterns (optional memo, conditional creation)
• Code patterns: ✅ Consistent with codebase conventions
• No obvious bugs: ✅

Minor Note:

SOLANA_MEMO_PROGRAM_ID is defined in both swapper/solana/constants.ts and Send/utils.ts. This appears intentional to avoid cross-package dependencies, which is acceptable.

---

QABot testing skipped due to RAM constraints - code review only

[gomesalexandre]

QA Testing

Tested with agent-browser (no qabot run - agent-browser session directly):

What was tested:

• SOL pool visible on /pools page with green status + APY
• Navigated to Add Liquidity for SOL.SOL pool
• LP type selector works (SOL only / SOL+RUNE / RUNE only) via data-testid
• Entered 0.006 SOL (~$0.50) asymmetric SOL deposit
• Quote loaded successfully (RUNE per SOL: 199.25, Share of Pool: 0.02%, Slippage: $0.000211)
• Clicked through lockup warning ("I understand")
• Confirmation screen showed correct details (0.006 SOL, Gas Fee: 0.00000513 SOL)
• Signed transaction - broadcast in progress (Solana tx was submitted to THORChain inbound 2Mm8k9sEwE6vUmhc8RF2EHStUNacVJjVQbNBEhoKsLNz)

Key fix in this PR:

• poolAssetHelpers.ts was lowercasing all AssetId keys in assetIdToThorPoolAssetIdMap, which corrupted Solana's case-sensitive base58 chain reference (5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp → 5eykt4usfv8p8njdtrepy1vzqkqzvdp). This caused fromAssetId() to throw in constants.ts, white-screening the entire app.
• Fix: keep original-case keys for iteration, use a separate lowercased map only for lookups.

Also added:

• data-testid="lp-type-asset", data-testid="lp-type-sym", data-testid="lp-type-rune" on LP type radio cards
• data-testid="lp-type-selector" on the radio group container
• data-testid="lp-deposit-button" on the Add Liquidity button

[coderabbitai]

🧹 Nitpick comments (1)

packages/swapper/src/thorchain-utils/solana/constants.ts (1)

1-3: Update dependent files to import from the new constants file.

This constant is defined in six locations across the codebase. The new packages/swapper/src/thorchain-utils/solana/constants.ts file exports MEMO_PROGRAM_ID, but the other files define their own local copies instead of importing it:

• packages/swapper/src/thorchain-utils/solana/getUnsignedSolanaTransaction.ts (line 10)
• packages/swapper/src/thorchain-utils/solana/getSolanaTransactionFees.ts (line 9)
• packages/swapper/src/thorchain-utils/getL1RateOrQuote.ts (line 62, as SOLANA_MEMO_PROGRAM_ID)
• src/components/Modals/Send/utils.ts (line 63, as SOLANA_MEMO_PROGRAM_ID)
• packages/unchained-client/src/solana/parser/thorchain.ts (line 6)

Consider updating these files to import from the new constants file to reduce duplication and improve maintainability.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/swapper/src/thorchain-utils/solana/constants.ts` around lines 1 - 3,
Multiple copies of the Solana memo program ID are defined locally; replace those
local constants (e.g. SOLANA_MEMO_PROGRAM_ID or hardcoded 'MemoSq4gq...') with a
single import of MEMO_PROGRAM_ID from the new constants file. Update callers in
getUnsignedSolanaTransaction, getSolanaTransactionFees, getL1RateOrQuote, the
Send modal utils, and the Solana parser (thorchain) to import MEMO_PROGRAM_ID
and remove the duplicated local constant definitions so all modules use the
exported MEMO_PROGRAM_ID.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/swapper/src/thorchain-utils/solana/constants.ts`:
- Around line 1-3: Multiple copies of the Solana memo program ID are defined
locally; replace those local constants (e.g. SOLANA_MEMO_PROGRAM_ID or hardcoded
'MemoSq4gq...') with a single import of MEMO_PROGRAM_ID from the new constants
file. Update callers in getUnsignedSolanaTransaction, getSolanaTransactionFees,
getL1RateOrQuote, the Send modal utils, and the Solana parser (thorchain) to
import MEMO_PROGRAM_ID and remove the duplicated local constant definitions so
all modules use the exported MEMO_PROGRAM_ID.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f41a7ec-42f4-47c5-8967-852405c6b98b

📥 Commits

Reviewing files that changed from the base of the PR and between 702ba59 and 2b79137.

📒 Files selected for processing (6)

• packages/swapper/src/swappers/ThorchainSwapper/utils/poolAssetHelpers/poolAssetHelpers.ts
• packages/swapper/src/thorchain-utils/solana/constants.ts
• src/components/Modals/Send/utils.ts
• src/lib/utils/thorchain/index.ts
• src/pages/ThorChainLP/components/AddLiquidity/AddLiquidityInput.tsx
• src/pages/ThorChainLP/components/LpType.tsx