feat: add wbtc.eth, usdt.sol, usdt.arb to chainflip supported assets#12137
feat: add wbtc.eth, usdt.sol, usdt.arb to chainflip supported assets#12137gomesalexandre merged 7 commits intodevelopfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR introduces support for three new assets in the Chainflip swapper: WBTC on Ethereum Mainnet, USDT on Arbitrum Mainnet, and USDT on Solana Mainnet. Two new AssetId constants are defined in the CAIP package, and the Chainflip swapper configuration is updated to include these assets in their respective chain support lists. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NeOMakinG
left a comment
There was a problem hiding this comment.
✅ Code Review — LGTM
Changes: Add new Chainflip supported assets:
- WBTC on Ethereum
- USDT on Solana
- USDT on Arbitrum
Verification:
- Asset IDs are correct (verified contract addresses)
- Added corresponding constants to @shapeshiftoss/caip
- Extends ChainflipSupportedAssetIdsByChainId correctly
- CI passes ✅
Clean asset addition.
qabot verification - new Chainflip assetsTested all 3 newly added assets on local dev (branch Curl API verification (Chainflip broker)
UI verification (trade widget, no wallet connected)
All 3 new assets successfully return Chainflip quotes in both the API and the UI. Chainflip consistently returns rates with ~2m 21.5s estimated execution time. Result: PASS - all new assets are correctly integrated and returning quotes. 🤖 Generated with Claude Code |
Description
wbtc.eth, usdt.sol, usdt.arb are now live on Chainflip mainnet. Adding them to the supported asset lists so they show up as swap routes.
wbtcAssetId,usdtOnArbitrumOneAssetId,usdtOnSolanaAssetIdconstants to@shapeshiftoss/caipChainflipSupportedAssetIdsByChainIdin the Chainflip swapperdynamic asset resolution in
getChainFlipIdFromAssetId()already matches by contract address + network, so no changes needed there.Issue (if applicable)
closes #11332
Risk
low - additive change, new swap pairs only. existing routes unaffected.
Chainflip swaps only.
Testing
Engineering
Operations
Screenshots (if applicable)
N/A
🤖 Generated with Claude Code
Summary by CodeRabbit