chore: clean up console warnings and minor fixes#12277
Conversation
- Remove deprecated `document-domain` Permissions-Policy header
- Use `scrollY.on('change', ...)` instead of deprecated `scrollY.onChange(...)`
- Prevent non-DOM Route props from leaking onto MobileNavLink Button
- Add optional chaining for appData.metadata in limit order filtering
- Remove noisy console.warn/log statements in market service and portals
- Remove unused catch variable in swapper utils
- Add fallback RPC URL spreads to ethereal and sei CSP configs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR refactors error handling and logging across multiple services, updates CSP configurations with additional RPC fallbacks, removes a header directive, modifies a Framer Motion API call pattern, simplifies a component's type signature, and improves null-safety in limit order filtering. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
General cleanup of console warnings, deprecation notices, and minor issues.
document-domainPermissions-Policy header (browsers no longer recognize it)scrollY.on('change', ...)instead of deprecatedscrollY.onChange(...)(framer-motion API update)<Button>elementappData.metadatain limit order filtering to prevent runtime errorsconsole.warn/console.logstatements in market service and portals utilsRisk
Low — no behavioral changes, only removing deprecated API usage, unnecessary logging, and fixing prop spreading.
None.
Testing
Engineering
document-domain,motion(),value.onChange, ormobileNavpropOperations
Screenshots (if applicable)
N/A
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Improvements
Refactor