Skip to content

chore: drop vite-plugin-checker and tidy vite config types#12304

Merged
kaladinlight merged 1 commit intodevelopfrom
chore/vite-config-cleanup
Apr 28, 2026
Merged

chore: drop vite-plugin-checker and tidy vite config types#12304
kaladinlight merged 1 commit intodevelopfrom
chore/vite-config-cleanup

Conversation

@kaladinlight
Copy link
Copy Markdown
Contributor

@kaladinlight kaladinlight commented Apr 28, 2026

Description

  • Remove vite-plugin-checker from the dev pipeline (and dependency). It was the dominant local dev perf bottleneck; CI and editor LSP already surface TypeScript errors.
  • Type publicFilesEnvVars as Record<string, string> so the dynamic VITE_SRI_* / VITE_CID_* keys built from the public/ directory type-check.
  • Suppress multiformats/cid|codecs/raw|hashes/sha2 imports with @ts-expect-error. multiformats v9 ships types but excludes them from its package exports, so TS can't resolve them. The package is only used at build time for SRI/CID computation, so suppressing inline is cleaner than declaring ambient modules.

Issue (if applicable)

closes #

Risk

Build/dev tooling only; no runtime app code changes. Dev type errors will no longer block via overlay — they still surface in editor and CI.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None.

Testing

Engineering

  • pnpm install then pnpm dev — confirm dev server starts and is noticeably faster on cold/warm boot
  • pnpm build — confirm production build still succeeds and emits SRI/CID env vars correctly
  • pnpm type-check — confirm no new TS errors

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed development dependency from the project
    • Updated build configuration and plugin settings
    • Enhanced TypeScript type checking with suppression annotations

@kaladinlight kaladinlight requested a review from a team as a code owner April 28, 2026 16:51
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@kaladinlight has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 43 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5fa8d5dd-cb52-48b2-947f-57a8a050721e

📥 Commits

Reviewing files that changed from the base of the PR and between 9498abc and 678fd8c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • vite.config.mts
📝 Walkthrough

Walkthrough

The PR removes the vite-plugin-checker development dependency and its integration from the Vite configuration. Additional refactoring adjusts async plugin hooks to synchronous, adds TypeScript suppression annotations for type-less imports, refines type constraints, and reformats build optimization expressions.

Changes

Cohort / File(s) Summary
Dependency Cleanup
package.json
Removes vite-plugin-checker from devDependencies.
Vite Configuration Refactoring
vite.config.mts
Removes vite-plugin-checker plugin integration and import. Changes two custom resolveId hooks (ethers v5 and bech32 v1) from async to synchronous. Adds TypeScript suppression comments for untyped multiformats imports. Constrains publicFilesEnvVars type to Record<string, string>. Reformats alias paths and manual chunk expressions for consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hopping through configs with cheer,
Vite checkers vanish, builds are clear!
Async hooks sync'd in a hop and a bound,
Cleaner and faster—no slowdown!
This rabbit approves of this tidy rewrite,

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: removing vite-plugin-checker and tidying Vite config types, which directly align with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/vite-config-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kaladinlight kaladinlight enabled auto-merge (squash) April 28, 2026 16:52
- remove vite-plugin-checker (CI/editor LSP cover TS errors; was the main local dev perf bottleneck)
- type publicFilesEnvVars as Record<string, string> for dynamic VITE_SRI_*/VITE_CID_* keys
- suppress multiformats imports whose package.json exports omit type entries

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kaladinlight kaladinlight force-pushed the chore/vite-config-cleanup branch from 9498abc to 678fd8c Compare April 28, 2026 16:54
@kaladinlight kaladinlight merged commit 1406fc1 into develop Apr 28, 2026
4 checks passed
@kaladinlight kaladinlight deleted the chore/vite-config-cleanup branch April 28, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant