chore(deps): allow nested @wagmi/core peer for reown adapter#12305
chore(deps): allow nested @wagmi/core peer for reown adapter#12305kaladinlight merged 2 commits intodevelopfrom
Conversation
@reown/appkit-adapter-wagmi → @wagmi/connectors@7.2.1 peer-needs @wagmi/core@3.4.0, which pnpm correctly nests under the adapter alongside the workspace's top-level @wagmi/core@2.22.1. With strictPeerDependencies: true, pnpm refuses to acknowledge the nested install and blocks pnpm i. Add @wagmi/core to allowedVersions to silence the strict check (no version override — both versions remain installed where their consumers expect them). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Description
pnpm iwas failing withERR_PNPM_PEER_DEP_ISSUES:```
packages/swap-widget
└─┬ @reown/appkit-adapter-wagmi 1.8.18
└─┬ @wagmi/connectors 7.2.1
└── ✕ unmet peer @wagmi/core@3.4.0: found 2.22.1
```
@reown/appkit-adapter-wagmiships with an old@wagmi/connectors@7.2.1that peer-requires@wagmi/core@3.4.0. pnpm already nests@wagmi/core@3.4.0under the adapter (verified innode_modules/@reown/appkit-adapter-wagmi/node_modules/@wagmi/core), alongside the top-level@wagmi/core@2.22.1used by the rest of the workspace. WithstrictPeerDependencies: true, pnpm only checks the visible (top-level) version and refuses to acknowledge the correctly-nested install.Adding
@wagmi/core: \"*\"topnpm.peerDependencyRules.allowedVersionssilences the strict check. This is not a version override — both@wagmi/core@2.22.1and@wagmi/core@3.4.0remain installed where their respective consumers expect them.Verified:
pnpm inow completes with no peer-dep errors.Issue (if applicable)
closes #
Risk
Dev tooling / install only. No code changes, no runtime behavior changes. Both wagmi core versions were already being installed in the same locations before this PR — only the strict peer-check error is silenced.
None.
Testing
Engineering
pnpm ifrom a clean state — confirm noERR_PNPM_PEER_DEP_ISSUESpnpm devandpnpm build— confirm wagmi/reown integrations still work in app and swap-widgetOperations
Screenshots (if applicable)
🤖 Generated with Claude Code