Skip to content

fix: placeholders in some app translations#12364

Merged
kaladinlight merged 5 commits into
shapeshift:developfrom
shapeshift-globalization:l10n
May 20, 2026
Merged

fix: placeholders in some app translations#12364
kaladinlight merged 5 commits into
shapeshift:developfrom
shapeshift-globalization:l10n

Conversation

@firebomb1
Copy link
Copy Markdown
Contributor

@firebomb1 firebomb1 commented May 20, 2026

Description

Fixes to existing translations that had missing/mismatching/translated placeholders in Japanese and Russian.

Risk

High Risk PRs Require 2 approvals

No. Only translations.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None.

Summary by CodeRabbit

  • Localization
    • Updated Japanese translations for Chainflip Lending screens with improved messaging and consistent placeholder formatting.
    • Corrected Russian translation placeholders and text strings for enhanced clarity and consistency across the app.

Review Change Stack

@firebomb1 firebomb1 self-assigned this May 20, 2026
@firebomb1 firebomb1 requested a review from a team as a code owner May 20, 2026 19:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7dc0e50-3cc7-4bf3-8b5c-413d6ce0efb1

📥 Commits

Reviewing files that changed from the base of the PR and between ef2561d and 918b3af.

📒 Files selected for processing (2)
  • src/assets/translations/ja/main.json
  • src/assets/translations/ru/main.json

📝 Walkthrough

Walkthrough

This PR updates localization files for Japanese and Russian languages. Japanese translations standardize amount placeholders and refine phrasing across lending flows. Russian translations correct placeholder variable names and fix translated text for limit orders, receive verification, and bridge features.

Changes

Translation Placeholder and Text Corrections

Layer / File(s) Summary
Japanese Lending Flow Translations
src/assets/translations/ja/main.json
Standardizes amount placeholders from %{金額} to %{amount} across supply success, borrow minimum loan, collateral minimum amount, withdraw conditions, and repay sections. Updates repay confirm and success descriptions to use %{amount} %{asset} format.
Russian Translation Corrections
src/assets/translations/ru/main.json
Corrects placeholder variables from non-standard names to standard i18n names: %{символ}%{symbol} in limit order warnings, updates address mismatch text to Russian, and fixes RFOX bridge destination network placeholder from %{сеть назначения} to %{destinationNetwork}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 With whiskers twitched and nose held high,
Translation placeholders now comply,
From %{金額} to clean %{amount},
Every language now will say the right amount! 🌍✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: placeholders in some app translations' directly and clearly describes the main change: correcting placeholder issues in translation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kaladinlight kaladinlight enabled auto-merge (squash) May 20, 2026 20:21
@kaladinlight kaladinlight merged commit 79ab4a0 into shapeshift:develop May 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants