Skip to content

Conversation

@gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 17, 2024

Description

See this review comment: #6168 (comment)

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

Very low

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

  • Confirm inbound_addresses is called at "Confirm and Deposit" step (only once, not refetched on click since there this isn't the proper signing step per se)
  • For additional paranoia testing, do the usual monkey patching

Operations

N/A, untestable by ops

Screenshots (if applicable)

image

Copy link
Contributor Author

gomesalexandre commented Feb 17, 2024

Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly what it says on the box!

Exactly one inbound_addresses call on pressing "Confirm and Deposit".

@0xApotheosis 0xApotheosis merged commit 611e2b7 into develop Feb 18, 2024
@0xApotheosis 0xApotheosis deleted the feat_lp_trading_active_improvements branch February 18, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants