Skip to content

Conversation

@kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Feb 19, 2024

Reverts #6248

To go in after: #6255

@kaladinlight kaladinlight marked this pull request as ready for review February 19, 2024 22:06
@kaladinlight kaladinlight requested a review from a team as a code owner February 19, 2024 22:06
@0xApotheosis 0xApotheosis changed the title fix: revert "fix: temporarily disable eip-1559 for keepkey" revert fix: temporarily disable eip-1559 for keepkey Feb 19, 2024
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming #6255 goes in this should be good to go too.

I updated the PR title to remove the double quotes, as I believe they cause issues with the release script.

@kaladinlight
Copy link
Contributor Author

Assuming #6255 goes in this should be good to go too.

I updated the PR title to remove the double quotes, as I believe they cause issues with the release script.

oh good to know, thanks!

@kaladinlight kaladinlight enabled auto-merge (squash) February 19, 2024 22:27
@kaladinlight kaladinlight merged commit 2289c38 into develop Feb 19, 2024
@kaladinlight kaladinlight deleted the revert-6248-fix-keepkey-trades-2 branch February 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants