fix: thor token repayments regression#6698
Merged
gomesalexandre merged 3 commits intodevelopfrom Apr 16, 2024
Merged
Conversation
gomesalexandre
changed the title
0xApotheosis
added a commit
that referenced
this pull request
Apr 17, 2024
This reverts commit 44660c3.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #6676 for the original PR, with this PR fixing the spotted bug in 1.574.0 (https://discord.com/channels/554694662431178782/1229606430173036546/1229636186822283386)
Pull Request Type
Issue (if applicable)
N/A
Risk
Low - ensure this time around, this indeed doesn't bring regression on non-token repayments, which I'm still unable to test because I don't have repayable position yet
Testing
Engineering
Operations
Screenshots (if applicable)