Merged
Conversation
Member
0xApotheosis
left a comment
0xApotheosis
left a comment
There was a problem hiding this comment.
Code looking good, one open question.
NeOMakinG
reviewed
Oct 14, 2024
Collaborator
NeOMakinG
left a comment
NeOMakinG
left a comment
There was a problem hiding this comment.
Small comments but looks sane overall!
1 task
kaladinlight
force-pushed
the
solana-chain-adapter
branch
from
2147854 to
ffa6013
Compare
0xApotheosis
approved these changes
Oct 15, 2024
Member
0xApotheosis
left a comment
0xApotheosis
left a comment
There was a problem hiding this comment.
Asset namespace issue resolved, good to go 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solana chain adapter support
Issue (if applicable)
closes #7739
Risk
Low - behind feature flag
Testing
Engineering
☝️
Operations
N/A
Screenshots (if applicable)