Skip to content

fix: allow ramp asset selection without wallet#8722

Merged
gomesalexandre merged 2 commits intodevelopfrom
fix-unselectable-ramp-asset
Feb 3, 2025
Merged

fix: allow ramp asset selection without wallet#8722
gomesalexandre merged 2 commits intodevelopfrom
fix-unselectable-ramp-asset

Conversation

@0xApotheosis
Copy link
Copy Markdown
Member

Description

Allows ramp assets to be selected without a wallet connected.

Issue (if applicable)

Closes #8600

Risk

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

On and off-ramping.

Testing

On the ramp page, ensure that ramp assets can be browsed and selected without a wallet connected.

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

Screenshot 2025-02-03 at 12 23 39

@0xApotheosis 0xApotheosis requested a review from a team as a code owner February 3, 2025 01:24
@gomesalexandre gomesalexandre self-requested a review February 3, 2025 15:10
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre gomesalexandre enabled auto-merge (squash) February 3, 2025 15:21
@gomesalexandre gomesalexandre merged commit f04c730 into develop Feb 3, 2025
@gomesalexandre gomesalexandre deleted the fix-unselectable-ramp-asset branch February 3, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buy/Sell page has asset locked on Eth when no wallet is connected- unable to search other asset

2 participants