fix: uni-v2 don't upsert ghost opportunities#8727
Merged
0xApotheosis merged 3 commits intodevelopfrom Feb 3, 2025
Merged
Conversation
NeOMakinG
approved these changes
Feb 3, 2025
Collaborator
NeOMakinG
left a comment
NeOMakinG
left a comment
There was a problem hiding this comment.
This branch
Develop
Pre-stamping but I had to nuke my cache so it needs a migration! 🙏
gomesalexandre
force-pushed
the
feat_uni_v2_ghost_opportoonities
branch
from
db14c21 to
5a9748a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We technically support all UNI-V2 opportunities as first-class, not just UNI-V2, but we actually don't because these are perf bottlenecks.
This ensures ghost opportunities are not upserted anywhere, resulting in ghost balances/eligible opportunities.
Issue (if applicable)
closes #8720
Risk
Low
Testing
Engineering
Operations
Screenshots (if applicable)