Skip to content

fix: global search enter keydown#8728

Merged
0xApotheosis merged 1 commit intodevelopfrom
fix_stop_bubble_butt_on
Feb 3, 2025
Merged

fix: global search enter keydown#8728
0xApotheosis merged 1 commit intodevelopfrom
fix_stop_bubble_butt_on

Conversation

@gomesalexandre
Copy link
Copy Markdown
Contributor

Description

Fixes the ENTER keypress not closing the global asset search modal.

Issue (if applicable)

closes #8674

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

  • Select an asset in global search modal and confirm pressing ENTER closes the modal
  • Select an asset in global search modal and confirm clicking the button closes the modal

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/f723dbbb-2c2c-4826-91f1-d8b47e37aa24

@gomesalexandre gomesalexandre requested a review from a team as a code owner February 3, 2025 17:15
Copy link
Copy Markdown
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the thing, a nice QOL fix 🙏

@0xApotheosis 0xApotheosis merged commit c79c9e8 into develop Feb 3, 2025
@0xApotheosis 0xApotheosis deleted the fix_stop_bubble_butt_on branch February 3, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hitting ENTER on asset search modal removes asset name and doesn't close modal

2 participants