Skip to content

fix: uni-v2 opportunities double-counted in total (the actual fix for real this time 🙅🧢)#8733

Merged
NeOMakinG merged 1 commit intodevelopfrom
fix_uni_v2_double_opportunities_the_actual_fix_for_real_this_time
Feb 4, 2025
Merged

fix: uni-v2 opportunities double-counted in total (the actual fix for real this time 🙅🧢)#8733
NeOMakinG merged 1 commit intodevelopfrom
fix_uni_v2_double_opportunities_the_actual_fix_for_real_this_time

Conversation

@gomesalexandre
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre commented Feb 3, 2025

Description

Actually does what it says on the box.

Issue (if applicable)

closes N/A

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low (read: the actual fix)

Testing

  • UNI-V2 opportunities are not double-counted in the grand total for UNI-V2

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

image

@gomesalexandre gomesalexandre requested a review from a team as a code owner February 3, 2025 23:40
@gomesalexandre gomesalexandre changed the title fix: uni-v2 opportunities double-counted in total (the actual fix for real this time no 🧢 fix: uni-v2 opportunities double-counted in total (the actual fix for real this time no 🧢) Feb 3, 2025
Comment thread src/state/slices/opportunitiesSlice/resolvers/uniV2/index.ts
@twblack88
Copy link
Copy Markdown
Contributor

is.SUS => false

@gomesalexandre gomesalexandre changed the title fix: uni-v2 opportunities double-counted in total (the actual fix for real this time no 🧢) fix: uni-v2 opportunities double-counted in total (the actual fix for real this time 🙅🧢) Feb 3, 2025
Copy link
Copy Markdown
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch

image

Prod

image

The actual good looking PR for real this time

@NeOMakinG NeOMakinG merged commit bca171f into develop Feb 4, 2025
@NeOMakinG NeOMakinG deleted the fix_uni_v2_double_opportunities_the_actual_fix_for_real_this_time branch February 4, 2025 00:17
gomesalexandre added a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants