Merged
Conversation
gomesalexandre
approved these changes
Apr 9, 2025
Contributor
gomesalexandre
left a comment
gomesalexandre
left a comment
There was a problem hiding this comment.
LGTM
- develop
- this diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#9261 renamed the placeholder
%{extra}to%{extraPercent}in the English copy (trade.tradeCompleteSurplus) but left the translations with the old placeholder name so non-English user do not see a value but%{extra}instead of the actual value currently when they get this message.That's one edge case in which updating translations could be done outside of the flow I guess, any element that is not translated but gets changed in English 😅 (placeholders, tags, brands and asset tickers)
Risk
None. Only translations.
None.
Testing
In trade with surplus and using non-English languages the surplus value should be displayed.
Engineering
☝️
Operations
☝️