Skip to content

fix: consider empty wallet as no wallet in asset search#9309

Merged
0xApotheosis merged 2 commits intodevelopfrom
fix_empty_wallet
Apr 10, 2025
Merged

fix: consider empty wallet as no wallet in asset search#9309
0xApotheosis merged 2 commits intodevelopfrom
fix_empty_wallet

Conversation

@gomesalexandre
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre commented Apr 9, 2025

Description

As mentioned in the inline comment, since we're not returning out zero'd out balances on assets we don't know of (i.e we don't know what we don't know until the user actually has a balance),
considers the "fresh wallet without a balance" situation the same as having no wallet connected.

Issue (if applicable)

closes #9299

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low, effectively the exact same logic as no wallet connected

Testing

  • No wallet connected and a fresh wallet with 0 balances should return the same results in asset search e.g receive modal
  • RUNE should be displayed in asset search e.g receive modal

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/eda92630-02d0-4ba8-8b55-308634f7ffa0

@gomesalexandre gomesalexandre marked this pull request as ready for review April 9, 2025 21:05
@gomesalexandre gomesalexandre requested a review from a team as a code owner April 9, 2025 21:05
Copy link
Copy Markdown
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does as promised!

develop vs this branch:

Screenshot 2025-04-10 at 2 07 07 pm

@0xApotheosis 0xApotheosis merged commit 1e8676c into develop Apr 10, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the fix_empty_wallet branch April 10, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to find Rune receive address on a new wallet

2 participants