In the validator package, there are a number of validations that check many aspects of incoming messages.
- In the class
ReferencedRequestMessageIdInResponseValidator there is a call to
UftpMessageSupport.getDuplicateMessage(),
for response messages this is not correct. A request response should be checked on whether it is a response to an existing flex request, so the flex request ID should be checked with
UftpMessageSupport.findReferencedMessage()
- There is no unit test to check this.
- The class should be renamed to
ReferencedFlexRequestMessageIdInResponseValidator to make the naming more consistent with other validators.
In the validator package, there are a number of validations that check many aspects of incoming messages.
ReferencedRequestMessageIdInResponseValidatorthere is a call toUftpMessageSupport.getDuplicateMessage(),for response messages this is not correct. A request response should be checked on whether it is a response to an existing flex request, so the flex request ID should be checked with
UftpMessageSupport.findReferencedMessage()ReferencedFlexRequestMessageIdInResponseValidatorto make the naming more consistent with other validators.