Skip to content

Wrong check in ReferencedRequestMessageIdInResponseValidator #65

@eelcodenheijer

Description

@eelcodenheijer

In the validator package, there are a number of validations that check many aspects of incoming messages.

  1. In the class ReferencedRequestMessageIdInResponseValidator there is a call to
    UftpMessageSupport.getDuplicateMessage(),

for response messages this is not correct. A request response should be checked on whether it is a response to an existing flex request, so the flex request ID should be checked with

UftpMessageSupport.findReferencedMessage()

  1. There is no unit test to check this.
  2. The class should be renamed to ReferencedFlexRequestMessageIdInResponseValidator to make the naming more consistent with other validators.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions