fix #2 via a property settable in tests.#7
Merged
Conversation
Alternate method of fixing this issue which allows tests to run in both Release or Debug configurations via a new DEBUG build only configuration variable in LogPrivacy which may be set in tests.
GeekAndDad
referenced
this pull request
Sep 29, 2021
shaps80
approved these changes
Sep 29, 2021
Owner
shaps80
left a comment
shaps80
left a comment
There was a problem hiding this comment.
Agreed, this is great. I hadn't considered a static property that's only available in DEBUG, I love this approach. Also as you mentioned, it resolves the unsafeFlags issue so I'm gonna merge and release this. Thanks @GeekAndDadDad
Contributor
Author
|
You're welcome. I was tempted to remove the .xcscheme file entirely but didn't know if there was anything else you'd intentionally set it in for other reasons. Might as well remove it if there isn't any other reason for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2
Describe your changes
From the commit: Alternate method of fixing this issue which allows tests to run in both Release or Debug configurations via a new DEBUG build only configuration variable in
LogPrivacywhich may be set in tests.