Skip to content

Add missing leaderboard dependency#117

Merged
avital merged 1 commit intoshare:masterfrom
curran:patch-2
Sep 25, 2016
Merged

Add missing leaderboard dependency#117
avital merged 1 commit intoshare:masterfrom
curran:patch-2

Conversation

@curran
Copy link
Copy Markdown
Contributor

@curran curran commented Aug 31, 2016

Closes #116

This is the result from npm install -S sharedb-mingo-memory. After this install, the demo worked correctly for me.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 31, 2016

Coverage Status

Coverage remained the same at 95.828% when pulling 2a5751c on curran:patch-2 into b33bdd5 on share:master.

@curran
Copy link
Copy Markdown
Contributor Author

curran commented Aug 31, 2016

I believe this will also close #89

@curran
Copy link
Copy Markdown
Contributor Author

curran commented Sep 17, 2016

Any thoughts on this fix?

@avital
Copy link
Copy Markdown
Contributor

avital commented Sep 25, 2016

Thanks for the PR, sorry it took so long.

@avital avital merged commit 0769524 into share:master Sep 25, 2016
@curran
Copy link
Copy Markdown
Contributor Author

curran commented Sep 25, 2016

@avital Thanks for merging! No problem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants