Update dev dependencies, replace Node 18 with Node 24 in CI#706
Open
ericyhwang wants to merge 8 commits intomasterfrom
Open
Update dev dependencies, replace Node 18 with Node 24 in CI#706ericyhwang wants to merge 8 commits intomasterfrom
ericyhwang wants to merge 8 commits intomasterfrom
Conversation
Node 18 has been EoL for a year. Also, dev deps sinon 19+, chai 5+, and sinon-chai 4+ require at least Node 20, since require(esm) was only backported as far back as Node 20 - https://joyeecheung.github.io/blog/2025/12/30/require-esm-in-node-js-from-experiment-to-stability/\#Backporting-require-esm-to-v22-and-v20-LTS
…anscluded from sharedb-mongo tests
…ead of clock.tickAsync()
Using setTickMode({mode: "nextAsync"}) together with clock.tickAsync() can trigger a fake-timers bug that causes Mocha to hang after test suite completion (sinonjs/fake-timers#564)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextTickby default, which causes some tests using fake timers to fail.clock.setTickMode({mode: 'nextAsync'});, but that caused the sharedb-mongo tests' Mocha process to hang after test suite completion. Went down a debugging rabbit-hole, and ended up filing Under "nextAsync" tick mode, using tickAsync() without awaiting can cause Mocha process to hang after suite completion sinonjs/fake-timers#564useFakeTimerswrapper in test/util.js that sets a defaulttoFakelist with just the ones that matter to us, and I've also switched theclock.tickAsync()calls (which weren't being awaited/then-ed) toclock.tick().test/.jshintrcfile, we missed it when migrating to ESLintTechnically, we should major version for dropping Node 18, though the sharedb library itself should still run fine on Node 18 since it doesn't use anything in Node 20+. Note that Node 20's going EoL in less than a month, so we could just wait until then to major version.