Added "data-no-hover" option to show just the share icons.#18
Closed
pserwylo wants to merge 2 commits intoshareNice-org:masterfrom
Closed
Added "data-no-hover" option to show just the share icons.#18pserwylo wants to merge 2 commits intoshareNice-org:masterfrom
pserwylo wants to merge 2 commits intoshareNice-org:masterfrom
Conversation
This attribute changes the default behaviour, so that it always shows the icons. As such, the shareNice icon and the "share-label" will not be displayed.
What was a "false || hasAttribute(...)" was inverted to "true || !hasAttribute(...)".
Author
|
Haha, bugger. Sorry, I didn't check out @aleksen's pull request first. Turns out we did the exact same thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having this attribute allows the default behaviour to be changed, so that you can see all of the icons without having to hover. Therefore, the default icon and the share-label are not displayed.
The end result is that when you visit the page, you see:
instead of:
I've updated the technical docs to describe this too.