fix: Framework module was missing some dependencies#13
Merged
lukeskrzypek-sf merged 1 commit intomainfrom Jul 30, 2025
Merged
Conversation
Framework module (ShareFile) was missing some dependencies, specifically System.Buffers.dll. This caused a stack overflow when trying to resolve it via our manual binding redirect as it couldn't be found. Also incremented version and added publish profiles for both targets.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a stack overflow issue in the ShareFile module by adding missing dependencies (System.Buffers.dll and System.Management.Automation.dll) to the installer. The issue occurred because the manual binding redirect couldn't resolve these missing dependencies.
- Added missing System.Buffers.dll and System.Management.Automation.dll to the installer
- Incremented version to 1.0.2.0 across project and installer files
- Updated source path to use publish folder instead of direct bin folder
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ShareFileModule/ShareFileModule.csproj | Version increment from 1.0.1.0 to 1.0.2.0 |
| ShareFileModule/Properties/PublishProfiles/NetFramework.pubxml | New publish profile for .NET Framework target |
| ShareFileModule-Installer/Product.wxs | Added missing System.Buffers.dll and System.Management.Automation.dll components |
| ShareFileModule-Installer/Globals.wxi | Version update and source path change to publish folder |
zmj-sf
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework module (ShareFile) was missing some dependencies, specifically System.Buffers.dll. This caused a stack overflow when trying to resolve it via our manual binding redirect as it couldn't be found.
This fixes the issue by adding the missing dependencies to the installer.
I also incremented the version to 1.0.2.0, and added publish profiles for both targets.