Add server ping/pong test coverage#21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds regression test coverage for server-initiated WebSocket ping/pong handling (Issue #11), ensuring the client responds with pong and the connection remains usable. It also extends the test WebSocket server harness to emit ping frames and observe pong payloads.
Changes:
- Added a new system WebSocket test that sends a server ping, asserts the server receives the expected pong payload, and verifies the client can continue receiving application messages.
- Extended the test
WebSocketServerharness with a.ping(Data)output event and apongPublisherto observe pong frames from the client. - Reduced an inverted-expectation wait timeout in an existing test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Tests/WebSocketTests/SystemWebSocketTests.swift | Adds server ping/pong regression test; tweaks an inverted-expectation timeout. |
| Tests/WebSocketTests/Server/WebSocketServer.swift | Adds ping output handling and publishes received pong payloads for tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
160
to
164
| else { return XCTFail("Received wrong error: \(error)") } | ||
| } | ||
|
|
||
| await fulfillment(of: [secondCloseEx], timeout: 0.1) | ||
| await fulfillment(of: [secondCloseEx], timeout: 0.05) | ||
| } |
Comment on lines
+362
to
+364
| subject.send(.message(.text("still open"))) | ||
| await fulfillment(of: [receivedEx], timeout: 2) | ||
| await fulfillment(of: [closeEx], timeout: 0.05) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11